Only new selectors #195
Merged
Only new selectors #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Made new-style selectors public and restrict old-style to the crate. * Improved output-formatting of new-style selectors. * Partially implmented filtering out placeholders from new-style selectors.
The conversion from sass selectors to css selectors (i.e. the evaluation of string interpolations in selectors) are still done through the old css selectors. The selectors context in a variable scope is now new selectors. Writing new selectors is now don to `CssBuf` (handling different formats) rather than through the `Display` trait. Improved new pseudo selectors and some other selector handling using a three-state option that can be "these selectors", "match-noting", or "match anything".
kaj
force-pushed
the
only-new-selectors
branch
5 times, most recently
from
40ecb98
to
f609c6e
Compare
* Evaluate sass selectors directly to new-style css selectors. * Purge the old style css selectors from the code-base!
kaj
force-pushed
the
only-new-selectors
branch
3 times, most recently
from
ac2de23
to
643a484
Compare
kaj
force-pushed
the
only-new-selectors
branch
4 times, most recently
from
8ba98b7
to
13cee52
Compare
kaj
force-pushed
the
only-new-selectors
branch
2 times, most recently
from
660f764
to
9ac076a
Compare
kaj
force-pushed
the
only-new-selectors
branch
from
8ba7147
to
ce63a86
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a breaking change.
The new "logical" selector types that was introduced for use in some sass selector functions is now the single implementation of css selectors, and the old css selector types are gone.
The sass selector types (that can contain string interpolations) is largely unchanged, except for the return type of the function evaluating it to css selectors.
This also fixes some special cases where the old implementation evaluated selectors incorrectly.